[GitHub] [daffodil-vscode] Shanedell commented on a change in pull request #85: Image, Icon, README Fixes

Fri, 18 Feb 2022 08:53:06 -0800 


Shanedell commented on a change in pull request #85:
URL: https://github.com/apache/daffodil-vscode/pull/85#discussion_r810174809



##########
File path: package.json
##########
@@ -10,7 +10,7 @@
   "engines": {
     "vscode": "^1.55.0"
   },
-  "icon": "images/daffodil.jpg",
+  "icon": "images/daffodil.png",

Review comment:
       So this icon will appear when you install extension. 
   
   Here is a screenshot of mine with the current image
   
   ![Screen Shot 2022-02-18 at 11 46 54 
AM](https://user-images.githubusercontent.com/32347414/154726047-a0f5fb11-b807-420b-a819-b9afd7ef3254.png)
   
   This is with the image you linked
   
   ![Screen Shot 2022-02-18 at 11 50 24 
AM](https://user-images.githubusercontent.com/32347414/154726606-8bb3bb62-b033-44c8-8f1b-0a5759de8d3a.png)
   
   Which do you prefer? I personally prefer the image you linked.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to