stevedlawrence commented on a change in pull request #85:
URL: https://github.com/apache/daffodil-vscode/pull/85#discussion_r810179341
##########
File path: package.json
##########
@@ -10,7 +10,7 @@
"engines": {
"vscode": "^1.55.0"
},
- "icon": "images/daffodil.jpg",
+ "icon": "images/daffodil.png",
Review comment:
Yeah, I think the .ico looks better. I also found the [VS Code
package.json
documentation](https://code.visualstudio.com/api/references/extension-manifest)
that says the icon property is:
> The path to the icon of at least 128x128 pixels (256x256 for Retina
screens).
Doesn't say anything about the supported formats, but it looks like the .ico
works for you. And I believe the .ico file has a bunch of built-in
resolutions, ranging from 16x16 to 256x256, so should scale nicely if VS Code
uses it anywhere else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
