stevedlawrence commented on code in PR #117:
URL: https://github.com/apache/daffodil-vscode/pull/117#discussion_r885550533


##########
package.json:
##########
@@ -392,6 +474,99 @@
             "default": ""
           }
         }
+      },
+      {
+        "type": "object",
+        "title": "vscode-dfdl",
+        "properties": {
+          "vscode-dfdl.enabled": {
+            "type": "boolean",
+            "default": true,
+            "description": "Enables the highlighting and status bar",
+            "scope": "resource"
+          },
+          "vscode-dfdl.showPath": {
+            "type": "boolean",
+            "default": true,
+            "description": "Enables showing tag's path in status bar",
+            "scope": "resource"
+          },
+          "vscode-dfdl.showRuler": {
+            "type": "boolean",
+            "default": true,
+            "description": "Enables showing highlighted tag pair in ruler 
section",
+            "scope": "resource"
+          },
+          "vscode-dfdl.highlightSelfClosing": {
+            "type": "boolean",
+            "default": false,
+            "description": "Should self-closing tags be highlighted",
+            "scope": "resource"
+          },
+          "vscode-dfdl.highlightFromContent": {
+            "type": "boolean",
+            "default": true,
+            "description": "Whether to highlight matching tag from inside the 
tag content",
+            "scope": "resource"
+          },
+          "vscode-dfdl.highlightFromName": {
+            "type": "boolean",
+            "default": true,
+            "description": "Whether to highlight matching tag from the tag 
name",
+            "scope": "resource"
+          },
+          "vscode-dfdl.highlightFromAttributes": {
+            "type": "boolean",
+            "default": true,
+            "description": "Whether to highlight matching tag from the tag 
attributes",
+            "scope": "resource"
+          },
+          "vscode-dfdl.noDefaultEmptyElements": {
+            "type": "boolean",
+            "default": false,
+            "description": "Don't use default HTML empty elements",
+            "scope": "resource"
+          },
+          "vscode-dfdl.customEmptyElements": {
+            "type": "array",
+            "default": null,
+            "description": "Custom empty elements in addition to the default 
HTML empty elements",
+            "scope": "resource"
+          },
+          "vscode-dfdl.styles": {

Review Comment:
   My concern is with other themes. Hardcoding colors is bound to conflict with 
some themes. What things are having their colors changed by this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to