stevedlawrence commented on code in PR #117:
URL: https://github.com/apache/daffodil-vscode/pull/117#discussion_r885724452
##########
package.json:
##########
@@ -27,22 +28,33 @@
"precompile": "node -p \"'export const LIB_VERSION = ' +
JSON.stringify(require('./package.json').version) + ';'\" > src/version.ts",
"compile": "tsc -p ./",
"lint": "yarn run prettier src -c",
- "watch": "webpack --watch --devtool nosources-source-map --info-verbosity
verbose --config ./build/extension.webpack.config.js",
+ "watch": "webpack --watch --devtool nosources-source-map --config
./build/extension.webpack.config.js",
"watch2": "tsc -watch -p ./",
"package": "vsce package",
"publish": "vsce publish",
"package-ext": "webpack --mode production --config
./build/extension.webpack.config.js",
"pretest": "yarn run compile",
"test": "node node_modules/mocha/bin/_mocha -u tdd --timeout 999999
--colors ./out/tests",
"sbt": "sbt universal:packageBin",
- "pre-build": "mv LICENSE tmp.LICENSE && mv NOTICE tmp.NOTICE && cp
build/bin.LICENSE LICENSE && cp build/bin.NOTICE NOTICE",
+ "pre-build": "run-script-os",
+ "pre-build:default": "mv LICENSE tmp.LICENSE && mv NOTICE tmp.NOTICE && cp
build/bin.LICENSE LICENSE && cp build/bin.NOTICE NOTICE",
+ "pre-build:windows": "move LICENSE tmp.LICENSE && move NOTICE tmp.NOTICE
&& copy build/bin.LICENSE LICENSE && copy build/bin.NOTICE NOTICE",
"build": "yarn pre-build && yarn sbt && yarn install && yarn compile &&
yarn package && yarn post-build",
- "post-build": "rm -rf NOTICE LICENSE && mv tmp.LICENSE LICENSE && mv
tmp.NOTICE NOTICE"
+ "post-build": "run-script-os",
+ "post-build:default": "rm NOTICE && rm LICENSE && mv tmp.LICENSE LICENSE
&& mv tmp.NOTICE NOTICE",
+ "post-build:windows": "del /q NOTICE && del /q LICENSE && move tmp.LICENSE
LICENSE && move tmp.NOTICE NOTICE"
},
"dependencies": {
+ "@grpc/grpc-js": "^1.5.4",
+ "@types/moo": "^0.5.5",
"await-notify": "1.0.1",
"child_process": "^1.0.2",
+ "google-protobuf": "^3.19.4",
"hexy": "^0.3.1",
+ "minimist": "^1.2.5",
+ "moo": "^0.5.1",
+ "omega-edit": "0.9.7",
+ "run-script-os": "^1.1.6",
"unzip-stream": "^0.3.1",
Review Comment:
I thin npm is pretty notorious for pulling in a crazy amount of
dependencies. If you can reliably figure out which of those actually end up in
extensions.js then it's fine to limit it to a smaller number. But otherwise, we
need to list all dependencies.
Note that ALv2 dependendencies don't need to go in bin.LICENSE, and if they
don't have a NOTICE file (which seems likely) nothing needs to go in the
bin.NOTICE file either. So that might make things a little easier.
I thought this work was already done for the previous release, so only
new/updated dependencies need to be verified, if that's the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
