mike-mcgann commented on code in PR #919:
URL: https://github.com/apache/daffodil/pull/919#discussion_r1092216538


##########
project/Rat.scala:
##########
@@ -38,35 +38,42 @@ object Rat {
     // generated_code.[ch] examples
     file("daffodil-runtime2/src/test/c/examples"),
 
+    // Apache Rat thinks these files are binary since the file name contains 
".lib"
+    
file("daffodil-schematron/src/main/resources/META-INF/services/org.apache.daffodil.lib.api.ValidatorFactory"),
+    
file("daffodil-japi/src/test/resources/META-INF/services/org.apache.daffodil.lib.api.ValidatorFactory"),
+    
file("daffodil-sapi/src/test/resources/META-INF/services/org.apache.daffodil.lib.api.ValidatorFactory"),
+    
file("daffodil-lib/src/main/resources/META-INF/services/org.apache.daffodil.lib.api.ValidatorFactory"),
+    
file("daffodil-lib/src/test/resources/META-INF/services/org.apache.daffodil.lib.api.ValidatorFactory"),
+
     // test files that cannot include the Apache license without breaking tests
-    
file("daffodil-cli/src/test/resources/org/apache/daffodil/CLI/input/hextest.txt"),
-    
file("daffodil-cli/src/test/resources/org/apache/daffodil/CLI/input/input1.txt"),
-    
file("daffodil-cli/src/test/resources/org/apache/daffodil/CLI/input/input2.txt"),
-    
file("daffodil-cli/src/test/resources/org/apache/daffodil/CLI/input/input3.txt"),
-    
file("daffodil-cli/src/test/resources/org/apache/daffodil/CLI/input/input4.txt"),
-    
file("daffodil-cli/src/test/resources/org/apache/daffodil/CLI/input/input5.txt"),
-    
file("daffodil-cli/src/test/resources/org/apache/daffodil/CLI/input/input6.txt"),
-    
file("daffodil-cli/src/test/resources/org/apache/daffodil/CLI/input/input7.txt"),
-    
file("daffodil-cli/src/test/resources/org/apache/daffodil/CLI/input/input8.txt"),
-    
file("daffodil-cli/src/test/resources/org/apache/daffodil/CLI/input/input9.txt"),
-    
file("daffodil-cli/src/test/resources/org/apache/daffodil/CLI/input/input10.txt"),
-    
file("daffodil-cli/src/test/resources/org/apache/daffodil/CLI/input/input11.txt"),
-    
file("daffodil-cli/src/test/resources/org/apache/daffodil/CLI/input/input12.txt"),
-    
file("daffodil-cli/src/test/resources/org/apache/daffodil/CLI/input/input13.txt"),
-    
file("daffodil-cli/src/test/resources/org/apache/daffodil/CLI/input/input14.txt"),
-    
file("daffodil-cli/src/test/resources/org/apache/daffodil/CLI/input/input14.exi"),
-    
file("daffodil-cli/src/test/resources/org/apache/daffodil/CLI/input/input14.exisa"),
-    
file("daffodil-cli/src/test/resources/org/apache/daffodil/CLI/input/input15.txt"),
-    
file("daffodil-cli/src/test/resources/org/apache/daffodil/CLI/input/input16.txt"),
-    
file("daffodil-cli/src/test/resources/org/apache/daffodil/CLI/input/input18.json"),
-    
file("daffodil-cli/src/test/resources/org/apache/daffodil/CLI/input/input18.txt"),
-    
file("daffodil-cli/src/test/resources/org/apache/daffodil/CLI/input/input18.exi"),
-    
file("daffodil-cli/src/test/resources/org/apache/daffodil/CLI/input/input18.exisa"),
-    
file("daffodil-cli/src/test/resources/org/apache/daffodil/CLI/input/input19.txt"),
-    
file("daffodil-cli/src/test/resources/org/apache/daffodil/CLI/input/inputBig1M.txt"),
-    
file("daffodil-cli/src/test/resources/org/apache/daffodil/CLI/input/prefix.txt"),
-    
file("daffodil-cli/src/test/resources/org/apache/daffodil/CLI/input/test_DFDL-714.txt"),
-    
file("daffodil-cli/src/test/resources/org/apache/daffodil/CLI/input/uuid.txt"),
+    
file("daffodil-cli/src/test/resources/org/apache/daffodil/cli/input/hextest.txt"),
+    
file("daffodil-cli/src/test/resources/org/apache/daffodil/cli/input/input1.txt"),
+    
file("daffodil-cli/src/test/resources/org/apache/daffodil/cli/input/input2.txt"),
+    
file("daffodil-cli/src/test/resources/org/apache/daffodil/cli/input/input3.txt"),
+    
file("daffodil-cli/src/test/resources/org/apache/daffodil/cli/input/input4.txt"),
+    
file("daffodil-cli/src/test/resources/org/apache/daffodil/cli/input/input5.txt"),
+    
file("daffodil-cli/src/test/resources/org/apache/daffodil/cli/input/input6.txt"),
+    
file("daffodil-cli/src/test/resources/org/apache/daffodil/cli/input/input7.txt"),
+    
file("daffodil-cli/src/test/resources/org/apache/daffodil/cli/input/input8.txt"),
+    
file("daffodil-cli/src/test/resources/org/apache/daffodil/cli/input/input9.txt"),
+    
file("daffodil-cli/src/test/resources/org/apache/daffodil/cli/input/input10.txt"),
+    
file("daffodil-cli/src/test/resources/org/apache/daffodil/cli/input/input11.txt"),
+    
file("daffodil-cli/src/test/resources/org/apache/daffodil/cli/input/input12.txt"),
+    
file("daffodil-cli/src/test/resources/org/apache/daffodil/cli/input/input13.txt"),
+    
file("daffodil-cli/src/test/resources/org/apache/daffodil/cli/input/input14.txt"),
+    
file("daffodil-cli/src/test/resources/org/apache/daffodil/cli/input/input14.exi"),
+    
file("daffodil-cli/src/test/resources/org/apache/daffodil/cli/input/input14.exisa"),
+    
file("daffodil-cli/src/test/resources/org/apache/daffodil/cli/input/input15.txt"),
+    
file("daffodil-cli/src/test/resources/org/apache/daffodil/cli/input/input16.txt"),
+    
file("daffodil-cli/src/test/resources/org/apache/daffodil/cli/input/input18.json"),
+    
file("daffodil-cli/src/test/resources/org/apache/daffodil/cli/input/input18.txt"),
+    
file("daffodil-cli/src/test/resources/org/apache/daffodil/cli/input/input18.exi"),
+    
file("daffodil-cli/src/test/resources/org/apache/daffodil/cli/input/input18.exisa"),
+    
file("daffodil-cli/src/test/resources/org/apache/daffodil/cli/input/input19.txt"),
+    
file("daffodil-cli/src/test/resources/org/apache/daffodil/cli/input/inputBig1M.txt"),
+    
file("daffodil-cli/src/test/resources/org/apache/daffodil/cli/input/prefix.txt"),
+    
file("daffodil-cli/src/test/resources/org/apache/daffodil/cli/input/test_DFDL-714.txt"),
+    
file("daffodil-cli/src/test/resources/org/apache/daffodil/cli/input/uuid.txt"),
     file("daffodil-io/src/test/resources/iso8859.doc.dat"),

Review Comment:
   Reverted Rat.scala and added it to the git-restore script. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to