tuxji commented on PR #919: URL: https://github.com/apache/daffodil/pull/919#issuecomment-1414178947
> What are thoughts on doing the PR that makes the actual OSGI changes now, and once that review has the +1's we can then merge and revert this PR. That keeps the scripts in commit history, but allows us to make any changes if the actual OSGI changes reveals any issues that needs changes to the scripts? Actually, this PR performs more changes than just adding the refactor scripts. This PR also adds the osgiCheck command to build.sbt (with project/OsgiCheck.scala), changes FieldFinder/TestFieldFinder to markdown, and adds some new ignored files to Rat.scala. We could simply delete the scripts directory in the still-to-come refactoring PR, otherwise all these additional changes need to be done either automatically by either the scripts or manually in the other PR instead of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
