mbeckerle commented on PR #919: URL: https://github.com/apache/daffodil/pull/919#issuecomment-1414472069
> > Is ths plan for these scripts to be committed to the repo, or is this PR just for review and will be closed and new PR opened with the actual changes? > > Well, I would not assume that a refactoring of this scope is needed only once. If we ever need to do another refactoring which is better done via scripts for reproducibility and review, these refactoring scripts written in both bash and scala have enough value and potential reuse that it's worth committing them to the repo and then removing them in the PR with the actual changes. That way, the scripts will be preserved in at least one commit within git history for possible future reuse. I'd rather keep these scripts in the code tree someplace, and not delete them and have to search the git history to find them. Absent a tag, if they're only in the history they're gone AFAIC. There are many more reasons why we may want to write scripts like this. I'd like to have a starting point of something that worked in the past without having to hunt for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
