mbeckerle commented on code in PR #947:
URL: https://github.com/apache/daffodil/pull/947#discussion_r1095160479
##########
daffodil-cli/src/main/scala/org/apache/daffodil/InfosetTypes.scala:
##########
@@ -108,22 +108,22 @@ object InfosetType extends Enumeration {
forPerformance: Boolean): InfosetHandler = {
infosetType match {
- case InfosetType.EXI => EXIInfosetHandler(dataProcessor)
- case InfosetType.EXISA => EXIInfosetHandler(dataProcessor, schemaUri.get)
- case InfosetType.JDOM => JDOMInfosetHandler(dataProcessor)
- case InfosetType.JSON => JsonInfosetHandler(dataProcessor)
- case InfosetType.NULL => NULLInfosetHandler(dataProcessor)
- case InfosetType.SAX => SAXInfosetHandler(dataProcessor, forPerformance)
+ case InfosetType.EXI => EXIInfosetHandler(dataProcessor)
+ case InfosetType.EXISA => EXIInfosetHandler(dataProcessor,
schemaUri.get)
+ case InfosetType.JDOM => JDOMInfosetHandler(dataProcessor)
+ case InfosetType.JSON => JsonInfosetHandler(dataProcessor)
+ case InfosetType.NULL => NULLInfosetHandler(dataProcessor)
+ case InfosetType.SAX => SAXInfosetHandler(dataProcessor,
forPerformance)
case InfosetType.SCALA_XML => ScalaXMLInfosetHandler(dataProcessor)
- case InfosetType.W3CDOM => W3CDOMInfosetHandler(dataProcessor)
- case InfosetType.XML => XMLTextInfosetHandler(dataProcessor)
+ case InfosetType.W3CDOM => W3CDOMInfosetHandler(dataProcessor)
+ case InfosetType.XML => XMLTextInfosetHandler(dataProcessor)
Review Comment:
I profoundly hate this aligning the arrows crap.
Only looks good on toy situations.
E.g., something more real like:
```
foo match {
case S(bar, baz) if (f(baz) == g(bar)) => // ok
case T(bar) => bar
case _ => Assert.invariantFailed("now I'm
completely out of line space to put this message.")
}
```
As soon as some condition is slightly more complex than the others, the
arrows all end up way off to the right and it is a mess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
