tuxji commented on PR #947:
URL: https://github.com/apache/daffodil/pull/947#issuecomment-1416079565
> I've also enabled import rewriting to sort and expand imports to multiple
lines. If these current changes are still too much, I can look into making it
much more conservative.
I like consistency, so I don't consider sorting imports too much. In fact,
the current scalafmt configuration seems to have left 45% of Daffodil's Scala
files unchanged and I see only whitespace changes to a few imports in the first
50% of the diffs (GitHub hides the remaining 50% of the diffs from view). If
scalafmt is really sorting the imports (can you check?), it must be matching
the order already being used, so that's a promising start.
However, I'll find one of these whitespace changes and comment on them there
since I think Mike will want to preserve these whitespace characters inside { }
imports (he put explicit instructions in an IDE setup page to ensure these
whitespace characters would be inserted).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
