stricklandrbls commented on code in PR #509:
URL: https://github.com/apache/daffodil-vscode/pull/509#discussion_r1143778006
##########
src/omega_edit/client.ts:
##########
@@ -26,6 +26,7 @@ import { DataEditWebView } from './dataEditWebView'
import { initOmegaEditClient } from './utils'
export let serverPort: number = 9000
+export let serverPortLock: boolean = false
Review Comment:
Adding an `undefined` union with `number` for serverPort causing errors to
propagate with functions or parameters that don't handle the `undefined`
portion of the union.
I just made it initially `0` and checking `>0` for active servers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
