stricklandrbls commented on PR #509: URL: https://github.com/apache/daffodil-vscode/pull/509#issuecomment-1478342104
> I am confused why are we only allowing a single instance? Shouldn't we be able to have multiple `omega-edit` instances, as long as they use different ports? We should also allow for the user to set the port we don't want a hard coded port that is always used. What if the hard coded port is already in use and the user wants to bind to a different port so they could use editor? Currently, listed as Issue #503, there are client/server implementations that cause multiple instances of the data editor, on different ports, to cause all the data editors to have the same port. Which corrupts the heartbeat validity and data editor logs. I originally implemented locking the server port to whichever the user specified but if the user: - Opened the data editor on port 9000 - Closed the editor - Opened another data editor on port 9001 This would cause the heartbeats to fail again. Essentially, whichever port the user initially specifies could be the only port used, during the lifetime of the VSCode application, that is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
