Shanedell commented on code in PR #509:
URL: https://github.com/apache/daffodil-vscode/pull/509#discussion_r1143887396
##########
src/omega_edit/client.ts:
##########
@@ -45,19 +45,21 @@ async function getOmegaEditPort(port: number | undefined =
undefined) {
const defaultServerPort = vscode.workspace
.getConfiguration('dataEditor')
.get<number>('defaultServerPort', serverPort)
Review Comment:
Can we rename `defaultServerPort` to `serverPort`. Since it can be updated I
don't think it should have `default` in the name as that makes me thing this
value shouldn't be set. This would need updated in the `package.json`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
