arosien commented on code in PR #694:
URL: https://github.com/apache/daffodil-vscode/pull/694#discussion_r1260007340


##########
debugger/src/main/resources/logback.xml:
##########
@@ -27,7 +27,17 @@
       <pattern>%date{ISO8601} [%thread] %highlight(%-5level) 
%cyan(%logger{15}) - %msg %n</pattern>
     </encoder>
   </appender>
-  <root level="DEBUG">
+
+  <appender name="FILE" class="ch.qos.logback.core.FileAppender">
+      <file>${LOG_FILE}</file>
+      <append>false</append>
+      <encoder>
+          <pattern>%date{ISO8601} [%thread] %highlight(%-5level) 
%cyan(%logger{15}) - %msg %n</pattern>

Review Comment:
   Concern: we don't want color highlighting in the files, they will just look 
weird when sent through normal tools like `less`. Or at least that's how it 
used to be.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to