arosien commented on code in PR #694:
URL: https://github.com/apache/daffodil-vscode/pull/694#discussion_r1260019278
##########
src/daffodilDebugger/utils.ts:
##########
@@ -33,32 +32,45 @@ export const daffodilArtifact = (version: string): Artifact
=> {
return new Artifact('daffodil-debugger', version, 'daffodil-debugger')
}
-export async function buildDebugger(baseFolder: string, filePath: string) {
- if (!filePath.includes('.vscode/extension')) {
- if (!fs.existsSync(filePath)) {
- let command = osCheck(
- 'sbt universal:packageBin',
- '/bin/bash --login -c "sbt universal:packageBin"'
- ) // Needed --login so it could resolve sbt command
+export async function buildDebugger(
Review Comment:
Concern: this function seems misplaced (within the extension itself).
Couldn't the `sbt` commands be added to the "extensionHost" launch config, so a
local launch of the extension would (optionally) ensure the local debugger
backend was updated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
