arosien commented on code in PR #694:
URL: https://github.com/apache/daffodil-vscode/pull/694#discussion_r1260028399
##########
src/daffodilDebugger/utils.ts:
##########
@@ -78,9 +90,11 @@ export async function runDebugger(
scriptPath,
artifact.scriptName,
createTerminal,
- shellArgs(artifact.scriptName, serverPort),
+ shellArgs(serverPort),
{
DAFFODIL_DEBUG_CLASSPATH: daffodilDebugClasspath,
+ LOG_LEVEL: debuggerLogLevel,
+ LOG_FILE: debuggerLogFilePath,
Review Comment:
```suggestion
DAFFODIL_DEBUGGER_LOG_LEVEL: debuggerLogLevel,
DAFFODIL_DEBUGGER_LOG_FILE: debuggerLogFilePath,
```
Env vars should be namespaced to avoid clobbering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
