tuxji commented on code in PR #1067:
URL: https://github.com/apache/daffodil/pull/1067#discussion_r1293733481
##########
daffodil-tdml-processor/src/test/scala/org/apache/daffodil/processor/tdml/TestDaffodilC.scala:
##########
@@ -137,7 +137,7 @@ class TestDaffodilC {
val input = new ByteArrayInputStream(b)
val pr = tdp.parse(input, b.length * 8)
assert(
- !pr.isProcessingError && pf.getDiagnostics.isEmpty,
+ !pr.isProcessingError,
Review Comment:
Yes, you're right, `pf.getDiagnostics.isEmpty` should be
`pr.getDiagnostics.isEmpty` (parse-time diagnostics, not schema compile/code
generation-time diagnostics).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
