stevedlawrence commented on code in PR #1067:
URL: https://github.com/apache/daffodil/pull/1067#discussion_r1293802472
##########
daffodil-tdml-processor/src/test/scala/org/apache/daffodil/processor/tdml/TestDaffodilC.scala:
##########
@@ -218,7 +218,6 @@ class TestDaffodilC {
cr match {
case Left(diagnostics) => fail(s"getProcessor failed:
${diagnostics.mkString}")
case Right((diagnostics, tdmlDFDLProcessor)) =>
- assert(diagnostics.isEmpty)
Review Comment:
I was hoping to leave all the updates to schemaLocations in a separate PR so
that 1) it's easier to look at the real changes if we ever need to come back to
it and 2) if we ever add a .git-blame-ignore-revs file then maybe the second
commit that updates all the schemaLocations could go in that. I would also like
to make sure all tests pass in both commits separately in case we ever need to
do a git bisect. So I'd rather we remove or change the assert so this test
passes without needing a schemaLocation updatew. I think something like this
should work and is maybe reasonable?
```scala
assert(diagnostics.forall(!_.isError))
```
It's maybe the same idea as what the original assert was checking for, but a
bit more robust against new warnings that might be added in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
