stevedlawrence commented on code in PR #1067:
URL: https://github.com/apache/daffodil/pull/1067#discussion_r1293762239
##########
daffodil-tdml-processor/src/test/scala/org/apache/daffodil/processor/tdml/TestDaffodilC.scala:
##########
@@ -218,7 +218,6 @@ class TestDaffodilC {
cr match {
case Left(diagnostics) => fail(s"getProcessor failed:
${diagnostics.mkString}")
case Right((diagnostics, tdmlDFDLProcessor)) =>
- assert(diagnostics.isEmpty)
Review Comment:
@tuxji, this place where I removed diagnostics is just about the
getProcessor call and not about parse/unparse diagnostics. Is it safe to keep
this one removed? Or maybe I an change it so that it only asserts that there
are no error error diagnostics, so that new warnings that get created (like
this one) do not break this test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
