scholarsmate commented on PR #883: URL: https://github.com/apache/daffodil-vscode/pull/883#issuecomment-1788315167
This is a nice new feature. We can see replaced sequences. <img width="1061" alt="Screenshot 2023-10-31 at 22 32 14" src="https://github.com/apache/daffodil-vscode/assets/2205472/fe8e20a1-0e17-49d8-bf2b-3f2a2fd342c8";> We can select a range of bytes to edit. <img width="1579" alt="Screenshot 2023-10-31 at 22 34 15" src="https://github.com/apache/daffodil-vscode/assets/2205472/b4975527-4ee4-4411-b03a-e7fe628609bb";> We can select a single byte to edit in-line. <img width="1584" alt="Screenshot 2023-10-31 at 22 34 41" src="https://github.com/apache/daffodil-vscode/assets/2205472/4648a476-e1b0-46b3-be3f-8c24c8f38c9a";> One minor inconsistency is that we we can close the multi-byte selection using the X in the 3rd column, but we lack that for the single byte selection. To "escape out of" single byte mode edit, ESC works, but doesn't "escape out of" multi-byte edit mode. It would be good to have ESC and the X work for both selection modes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
