scholarsmate commented on PR #883: URL: https://github.com/apache/daffodil-vscode/pull/883#issuecomment-1789126306
@stricklandrbls, that's right. If a 1M file of 'a's gets changed to 'xX' that's a lot to keep track of and will not scale well. I'd recommend doing the same here. Just highlight the last replacement and the current search. There will be no highlighting for replace all or replace rest since that's all done on the server side and is opaque on the client side. If I insert or delete bytes the highlights float on top and do not float with the content. If I delete or insert bytes in the middle of a selection, it doesn't shrink or grow. If I revert all changes, the highlights remain. Maybe the "fix" is to clear the selections when any edit is made or any change is undone/redone. I think it's still possible to show the last replacement and the current search, but any other change to the content clears the selections. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
