mbeckerle commented on code in PR #1158:
URL: https://github.com/apache/daffodil/pull/1158#discussion_r1487056541
##########
daffodil-runtime1/src/main/scala/org/apache/daffodil/runtime1/api/JPrimType.java:
##########
@@ -14,16 +14,29 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
+package org.apache.daffodil.runtime1.api;
-package org.apache.daffodil.runtime1.dpath
+public enum JPrimType {
Review Comment:
Javadoc.
This enum is easy to use from Java code.
##########
daffodil-runtime1/src/main/scala/org/apache/daffodil/runtime1/dpath/NodeInfo.scala:
##########
@@ -85,16 +82,16 @@ sealed abstract class TypeNode private (
) extends Serializable
with NodeInfo.Kind {
- def this(sym: Symbol, parents: => Seq[NodeInfo.Kind], children: =>
Seq[NodeInfo.Kind]) =
Review Comment:
Did you know type Symbol was removed from Scala in Scala 3. Possibly
earlier.
##########
daffodil-runtime1/src/main/scala/org/apache/daffodil/runtime1/dpath/NodeInfo.scala:
##########
@@ -298,36 +279,36 @@ object NodeInfo extends Enum {
def fromObject(a: Any) = {
a match {
- case x: String => NodeInfo.String
Review Comment:
This could be reverted.
I was thinking of removing NodeInfo's aliases for all the PrimType objects,
but it was too much trouble.
##########
daffodil-runtime1/src/main/scala/org/apache/daffodil/runtime1/api/JPrimType.java:
##########
Review Comment:
I have no idea why it thinks this is a rename of TestNodeInfo.scala
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
