mbeckerle commented on code in PR #1158: URL: https://github.com/apache/daffodil/pull/1158#discussion_r1488140970
########## daffodil-lib/src/main/scala/org/apache/daffodil/lib/util/Delay.scala: ########## @@ -65,7 +65,7 @@ import org.apache.daffodil.lib.exceptions.Assert * * }}} */ -final class Delay[T] private (private var box: Delay.Box[T], sym: Symbol) +final class Delay[T] private (private var box: Delay.Box[T], sym: AnyRef) Review Comment: These symbols were just used for debugging to identify what was going on. I wanted to eliminate use of symbols here and instead pass other kinds of context objects. (Java enum objects) All it needs to have is a toString method, so AnyRef is a reasonable type for this. In general yes getting rid of Symbol should be a separate matter. I will add Scaladoc explaining that these are just context objects used for debugging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
