mbeckerle commented on code in PR #1158:
URL: https://github.com/apache/daffodil/pull/1158#discussion_r1488161698


##########
daffodil-runtime1/src/main/scala/org/apache/daffodil/runtime1/api/JPrimType.java:
##########
@@ -14,16 +14,29 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+package org.apache.daffodil.runtime1.api;
 
-package org.apache.daffodil.runtime1.dpath
+public enum JPrimType {
 
-import org.junit.Assert.assertTrue
-import org.junit.Test
-
-class TestNodeInfo {
-
-  @Test def test_nodeInfoCanBeConstructed(): Unit = {
-    assertTrue(NodeInfo.isXDerivedFromY("Byte", "Long"))
-  }
+    String,
+    Int,
+    Byte,
+    Short,
+    Long,
+    Integer,
+    Decimal,
+    UnsignedInt,
+    UnsignedByte,
+    UnsignedShort,
+    UnsignedLong,
+    NonNegativeInteger,

Review Comment:
   These are a Java Enum representation of DFDL's simple types. 
   
   The fact that there are no unsigned types in Java is a separate issue that 
is addressed in trait InfosetSimpleElement where there are methods like 
getUnsignedLong which returns a JBigInt, and getUnsignedShort returns a JInt. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to