stevedlawrence commented on code in PR #1219:
URL: https://github.com/apache/daffodil/pull/1219#discussion_r1571130334
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/dsom/SequenceGroup.scala:
##########
@@ -346,7 +346,7 @@ object ChoiceBranchImpliedSequence {
* handled as a degenerate sequence having only one element decl within it.
*/
final class ChoiceBranchImpliedSequence private (rawGM: Term)
- extends SequenceTermBase(rawGM.xml, rawGM.optLexicalParent, rawGM.position)
+ extends SequenceTermBase(<sequence />, rawGM.optLexicalParent,
rawGM.position)
Review Comment:
An alternative approach I considered but did not investigate might be to
remove `ChoiceBranchImpliedSequence` entirely and instead have logic when
creating the choice parser/unparser to inspect the branches and wrap arrays
with the right Sequence parser/unparser.
This might simplify some logic (there are a number of places where we have
to check if something is the implied sequence and do something different), but
possibly makes the logic to create choice parser/unparser a bit more complex.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
