stevedlawrence commented on code in PR #1219:
URL: https://github.com/apache/daffodil/pull/1219#discussion_r1571310172
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/dsom/SequenceGroup.scala:
##########
@@ -346,7 +346,7 @@ object ChoiceBranchImpliedSequence {
* handled as a degenerate sequence having only one element decl within it.
*/
final class ChoiceBranchImpliedSequence private (rawGM: Term)
- extends SequenceTermBase(rawGM.xml, rawGM.optLexicalParent, rawGM.position)
+ extends SequenceTermBase(<sequence />, rawGM.optLexicalParent,
rawGM.position)
Review Comment:
Actually, I think we only wrap choice branches with an implied sequence for
branches that are arrays, since array occurrences are handle by the sequence
parser. If there's only a single element, or an explicit sequence, then we
already have a single parser for that branch and we don't need anything extra.
Agreed that ChoiceBranchImpliedSequence is likely the best approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
