tuxji commented on code in PR #1219:
URL: https://github.com/apache/daffodil/pull/1219#discussion_r1571262676
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/dsom/SequenceGroup.scala:
##########
@@ -346,7 +346,7 @@ object ChoiceBranchImpliedSequence {
* handled as a degenerate sequence having only one element decl within it.
*/
final class ChoiceBranchImpliedSequence private (rawGM: Term)
- extends SequenceTermBase(rawGM.xml, rawGM.optLexicalParent, rawGM.position)
+ extends SequenceTermBase(<sequence />, rawGM.optLexicalParent,
rawGM.position)
Review Comment:
Sounds good to me! I appreciate having this look at how choices work under
the hood, as it answers something I was wondering about (how does Daffodil
encapsulate choice branches which are not complex element references or
sequences, but rather single simple-type elements?). Now I know Daffodil
encapsulates them in a ChoiceBranchImpliedSequence with a dummy empty sequence
XML.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
