mbeckerle commented on code in PR #1375:
URL: https://github.com/apache/daffodil/pull/1375#discussion_r1847282004
##########
project/Dependencies.scala:
##########
@@ -53,7 +53,8 @@ object Dependencies {
lazy val test = Seq(
"junit" % "junit" % "4.13.2" % "test",
"com.github.sbt" % "junit-interface" % "0.13.3" % "test",
- "org.scalacheck" %% "scalacheck" % "1.18.1" % "test"
+ "org.scalacheck" %% "scalacheck" % "1.18.1" % "test",
+ "com.lihaoyi" %% "sourcecode" % "0.4.1"
Review Comment:
@stevedlawrence This is just a dependency for the tdml-lib now.
Li Haoyi's library is MIT license, which is Apache compatible.
While the CLI does run TDML tests, and so depends on daffodil-tdml-lib, it
isn't dependent on this feature, which is only used by Scala code that
explicitly creates calls to do the Runner.doTest method, which depends on this
sourcecode macro which is passed through to scala code users in the implicit
argument to doTest.
But should we add info about this library anyway just to be safe? I am not
sure CLI won't pull it in. I imagine it will just depend on everything that
daffodil-tdml-lib depends on?
This would mean adding to the CLI's bin.LICENSE file I believe.
Is there anyplace else to update on account of this dependency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
