stevedlawrence commented on code in PR #1375:
URL: https://github.com/apache/daffodil/pull/1375#discussion_r1847298203
##########
project/Dependencies.scala:
##########
@@ -53,7 +53,8 @@ object Dependencies {
lazy val test = Seq(
"junit" % "junit" % "4.13.2" % "test",
"com.github.sbt" % "junit-interface" % "0.13.3" % "test",
- "org.scalacheck" %% "scalacheck" % "1.18.1" % "test"
+ "org.scalacheck" %% "scalacheck" % "1.18.1" % "test",
+ "com.lihaoyi" %% "sourcecode" % "0.4.1"
Review Comment:
If `sourcecode` is a transitive dependency of the CLI via daffdodil-tdml,
then we *must* include license/notice information in
`daffodil-cli/bin.{LICENSE,NOTICE)`. All CLI transitive dependencies are
packaged/distributed in our CLI helper binaries whether they are used or not,
and anything packaged/distributed in there needs to be mentioned in the the CLI
specific license files. Transitive dependencies do not need to be listed
anywhere else since we don't distribute them, as long they are ASF compatible
or optional they are fine.
Note: See my other thought about whether this really wants to be part of
daffodil-sbt. It's pretty easy to add new dependencies via daffodil-sbt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
