stevedlawrence commented on code in PR #1375:
URL: https://github.com/apache/daffodil/pull/1375#discussion_r1847306329
##########
project/Dependencies.scala:
##########
@@ -53,7 +53,8 @@ object Dependencies {
lazy val test = Seq(
"junit" % "junit" % "4.13.2" % "test",
"com.github.sbt" % "junit-interface" % "0.13.3" % "test",
- "org.scalacheck" %% "scalacheck" % "1.18.1" % "test"
+ "org.scalacheck" %% "scalacheck" % "1.18.1" % "test",
+ "com.lihaoyi" %% "sourcecode" % "0.4.1"
Review Comment:
The more I think about this, I don't think this wants to be a source
dependency. It really just wants to be a "test" dependency for use by JUnit
files. If we want to also use it for schema projects, then we should modify
daffodil-sbt to also add it as a "test" dependency. That avoids the awkwardness
of distributing something with the CLI that is never used by the CLI. There's a
bit of duplication, but it makes it so we can use the `sourcecode` approach (or
the alternative junit approach) with any version of Daffodil for schema
projects. Otherwise to test with an older `daffodilVersion` you would need to
revert `runner.doTest` since `sourcecode` would only be pulled in for newer
versions of daffodil-lib. The fix is to then manually add `sourcecode`
dependency for those projects, but that's a pain when we could just add support
in daffodil-sbt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
