JeremyYao commented on code in PR #1197:
URL: https://github.com/apache/daffodil-vscode/pull/1197#discussion_r1987521780
##########
package.json:
##########
@@ -36,7 +36,7 @@
"watch:svelte": "yarn webpack --env development=true -w -c
./src/svelte/webpack.config.js",
"watch:svelte-tests": "mocha -r ts-node/register -w
./src/svelte/tests/**/*.test.ts",
"watch:tdmlEditorJS": "esbuild src/tdmlEditor/webview/webview.js
--outfile=dist/views/tdmlEditor/webview/webview.js --bundle --platform=node
--format=cjs --watch",
- "webpack": "webpack --mode production --config
./webpack/ext-dev.webpack.config.js",
+ "webpack": "webpack --mode development --config
./webpack/ext-dev.webpack.config.js",
Review Comment:
If `webpack` is only used for development things, then I feel like it's fine
to keep the mode as development.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
