JeremyYao commented on code in PR #1197: URL: https://github.com/apache/daffodil-vscode/pull/1197#discussion_r1995885978
########## src/tests/DfdlIntellisenseTestingChecklist.md: ########## @@ -0,0 +1,176 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> + +# The following tests use the file: src/tests/data/testDfdlMixedLineFormats.dfdl.xsd Review Comment: Would it help to let users know about the shortcut `CTRL` + `G` in VSCode which allows you to go to a specific line and column? (Eg: `46,28`) ########## src/tests/DfdlIntellisenseTestingChecklist.md: ########## @@ -0,0 +1,176 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> + +# The following tests use the file: src/tests/data/testDfdlMixedLineFormats.dfdl.xsd + +Place the cursor at line 29 column 44, after alignmentUnits="bytes" press the backspace key until alignmentUnits="bytes" is erased. Type CTRL+space. Select dfdl:alignmentUnits from the dropdown and bytes from the value dropdown. + +- [ ] Verify that alignmentUnits="bytes" is inserted. +- [ ] Verify that alignmentUnits does not have the dfdl: prefix. + +Place the cursor on line 46, column 28 at the end of the line <xs:group +name = "test" >. Type a space. + +- [ ] Verify drop down contains xs:annotation and xs:sequence. + +Place the cursor at the same position as above. Type CTRL+space + +- [ ] Verify drop down contains xs:annotation and xs:sequence. + +Place the cursor at line 48, column 18 at the end of the line +<xs:sequence>. Type a space or CTRL+space. + +- [ ] Verify dropdown contains xs:annotation, xs:choice, xs:element + name, xs:element ref, and xs:sequence. + +Place cursor at line 56, column 39 at the end of the line <xs:element +name="Keyword">. Type a space. + +- [ ] Verify dropdown contains dfdl:alignment, dfdl:alignmentUnits, + dfdl:binaryBooleanFalseRep, dfdl:binaryBooleanTrueRep, + dfdl:binaryNumberRep, dfdl:bitOrder, dfdl:byteOrder, + dfdl:choiceBranchKey, dfdl:encoding, dfdl:inputValueCalc, dfdl:length, + dfdl:lengthKind, dfdl:lengthPattern, dfdl:lengthUnits, dfdl:occursCount, + dfdl:occursCountKind, dfdl:outputNewLine dfdl:outputValueCalc, + dfdl:prefxIncludesPrefixLength, dfdl:prefixLengthType, + dfdl:representation, dfdl:terminator, maxOccurs, minOccurs, name, ref, + and type. + Note: This isn't a comprehensive list of attributes, just the most commonly used attributes. + +- [ ] Verify dropdown appears with above listed elements, and the first + line in dropdown is highlighted with a description of the highlighted + item beside it. + +- [ ] Verify a dropdown appears with the above listed elements and + pressing the down arrow key displays the description of each highlighted + element. + +Place the cursor at line 57 and hover over the attribute dfdl:alignment. + +- [ ] Verify a text box appears with a definition for dfdl:alignment. + +Place the cursor at line 57 column 47, within the double quotes with the value 1 for dfdl:alignment. +Type CTRL+space. + +- [ ] Verify the dropdown contains 1, 2, and implicit. + +Place the cursor at line 57 column 65, after dfdl:length="10". Type CTRL+space. Select dfdl:byteOrder from the dropdown and bigEndian for the value. Review Comment:  Bigger picture -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
