JeremyYao commented on code in PR #1197:
URL: https://github.com/apache/daffodil-vscode/pull/1197#discussion_r1995677077
##########
src/language/providers/utils.ts:
##########
@@ -49,10 +50,36 @@ const items = [
'import',
]
+export class XmlItem {
Review Comment:
An XmlItem that doesn't have a namespace? I'm guessing it would be `"none"`
from the code, but wouldn't it represent `none:<whatever goes here>`? Would it
be better presented as `private _itemNS:string | undefined = undefined`? If
it's `undefined`, it would mean the xml item doesn't belong to a namespace?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
