rthomas320 commented on code in PR #1197:
URL: https://github.com/apache/daffodil-vscode/pull/1197#discussion_r2001408038
##########
src/language/providers/utils.ts:
##########
@@ -49,10 +50,36 @@ const items = [
'import',
]
+export class XmlItem {
Review Comment:
The XmlItem was introduced to keep track of the an element/attribute name
and namespace. The use of none as the default values is to keep the returned
results compatible with the existing code. There are various places where a
return value of "none" changes the logic flow. I didn't want to re-work these
situations with this change, (I was trying to get the changes in for an end of
February release) but it can be looked at in future changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
