stevedlawrence commented on code in PR #1471:
URL: https://github.com/apache/daffodil-vscode/pull/1471#discussion_r2449627424


##########
vite/dev.vite.config.mjs:
##########
@@ -45,41 +45,30 @@ const packageData = jsoncParse(
 const pkg_version = packageData['version']
 const scalaVersions = ['2.12', '2.13', '3']
 
-function unzipAfterBuild() {
+function copyDebuggerOutAfterBuild() {

Review Comment:
   Now that we don't have to unzip anything, instead of copying files out, 
would it be possible to add a pattern in the `copyToPkgDirPlugin` function, 
something along the lines of:
   
   ```ts
       {
         from: 'debugger/target/jvm-${scalaVersion}/universal/stage',
         to: `${pkg_dir}/daffodil-debugger-${scalaVersion}-${pkg_version}`,
       },
   ```
   Probably wants to be a bit different to support the multiple scalaVersions, 
and I'm not postitive if those are the right directories, but something like 
that.
   
   The way things work right now is we copy the stage directories to the root 
of the repo and then copy those directories to pkg_dir. If we could reuse the 
existing pattern copy from/to code we could avoid the extra copy and also avoid 
polluting the repo root with intermediate build files.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to