shanedell commented on code in PR #1471:
URL: https://github.com/apache/daffodil-vscode/pull/1471#discussion_r2449864324


##########
vite/dev.vite.config.mjs:
##########
@@ -45,41 +45,30 @@ const packageData = jsoncParse(
 const pkg_version = packageData['version']
 const scalaVersions = ['2.12', '2.13', '3']
 
-function unzipAfterBuild() {
+function copyDebuggerOutAfterBuild() {

Review Comment:
   So currently the `dev.vite.config.mjs` does copy the files to the root 
directory. However, the `package.vite.config.mjs` does not copy them to the 
root directory and instead copies them to `dist/package`. The reason this is 
done is so that when either debugging the extension locally or running through 
a VSIX file the debuggers would be in the same root directory as the other 
relevant files.
   
   As for the `copyToPkgDirPlugin`, this would be something we can do the 
`package.vite.config.mjs`. However, we can not do it for `dev.vite.config.mjs` 
as we are not doing something similar there. So, would it be reasonable to 
implement what you said for `copyToPkgDirPlugin` for the 
`package.vite.config.mjs` but leave `dev.vite.config.js` copying out the 
debuggers once the build completes?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to