leerho commented on a change in pull request #324:
URL:
https://github.com/apache/incubator-datasketches-java/pull/324#discussion_r453006832
##########
File path: src/main/java/org/apache/datasketches/tuple/CompactSketch.java
##########
@@ -121,6 +121,11 @@
}
}
+ @Override
+ public CompactSketch<S> compact() {
+ return this;
+ }
Review comment:
Clearly doing toByteArray() would be very wasteful. The only knowledge
we have of the Summary is the two current methods: we can copy it and serialize
it to bytes. When we are serializing the sketch we have to call toByteArray()
anyway, so we grab its size at that point.
But adding this method would give us that visibility and I think it could be
useful. However, we don't want to make the requirements on the Summary too
restrictive as it may limit what the users want to do with it.
Perhaps the best way to resolve this would be to put a [DISCUSS] issue on
this topic on our dev@ list and see if anyone responds pro or con.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
