jmalkin commented on code in PR #400:
URL: https://github.com/apache/datasketches-cpp/pull/400#discussion_r1373970567
##########
tuple/include/array_tuple_a_not_b.hpp:
##########
@@ -28,14 +28,27 @@
namespace datasketches {
+/// array tuple A-not-B
template<typename Array, typename Allocator = typename Array::allocator_type>
class array_tuple_a_not_b: tuple_a_not_b<Array, Allocator> {
public:
using Base = tuple_a_not_b<Array, Allocator>;
using CompactSketch = compact_array_tuple_sketch<Array, Allocator>;
+ /**
+ * Constructor
+ * @param seed for the hash function that was used to create the sketch
+ * @param allocator to use for allocating and deallocating memory
+ */
explicit array_tuple_a_not_b(uint64_t seed = DEFAULT_SEED, const Allocator&
allocator = Allocator());
+ /**
+ * Computes the a-not-b set operation given two sketches.
+ * @param a sketch A
+ * @param b sketch B
+ * @param ordered optional flag to specify if ordered sketch should be
produced
+ * @return the result of a-not-b as a compact sketch
Review Comment:
Maybe A-not-B is more consistent with the input sketch names?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
