jmalkin commented on code in PR #400: URL: https://github.com/apache/datasketches-cpp/pull/400#discussion_r1373971671
########## tuple/include/array_tuple_sketch.hpp: ########## @@ -116,6 +111,10 @@ template<typename Array, typename Allocator> class compact_array_tuple_sketch; /** * Update array tuple sketch. + * This is a wrapper around tuple sketch to match the functionality and serialization format of ArrayOfDoublesSketch in Java. + * For this the sketch must be configured with array<double> or std::vector<double>. + * This is a more generic implementation for any integral type (serialization assumes contiguous array size_of(T) * num_values). Review Comment: Numeric type, not integral -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
