jmalkin commented on code in PR #400:
URL: https://github.com/apache/datasketches-cpp/pull/400#discussion_r1373972137
##########
tuple/include/tuple_a_not_b.hpp:
##########
@@ -37,11 +37,19 @@ class tuple_a_not_b {
using AllocEntry = typename std::allocator_traits<Allocator>::template
rebind_alloc<Entry>;
using State = theta_set_difference_base<Entry, ExtractKey, CompactSketch,
AllocEntry>;
+ /**
+ * Constructor
+ * @param seed for the hash function that was used to create the sketch
+ * @param allocator to use for allocating and deallocating memory
+ */
explicit tuple_a_not_b(uint64_t seed = DEFAULT_SEED, const Allocator&
allocator = Allocator());
/**
* Computes the a-not-b set operation given two sketches.
- * @return the result of a-not-b
+ * @param a sketch A
Review Comment:
Same as above with A vs a but probably don't bother changing either place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
