PointKernel commented on issue #502: URL: https://github.com/apache/datasketches-cpp/issues/502#issuecomment-4513822649
+1 for the new structural layout, both fixes are overdue: generic names like `optional.hpp` are a real collision risk for downstream integrators, and a `detail/` boundary keeps implementation headers from quietly becoming ABI contracts. Worth noting this doesn't have to be a breaking change in one cut: move every header to its new location and leave the old paths as thin facade headers that just `#include` the new ones with a `[[deprecated]]` attribute (if available as it's c++14 or newer) and a `@deprecated` note for one or two releases, giving downstream consumers a deprecation window before the shims get removed in the major bump. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
