sleeepyjack commented on issue #502:
URL:
https://github.com/apache/datasketches-cpp/issues/502#issuecomment-4514061043
Agree the file/class shape needs to land somewhere that doesn't make
multi-sketch usage awkward.
One nuance worth surfacing: in C++ the filename and the class name are
independent, so even under Option A the classes themselves can keep
distinguishing prefixes:
```cpp
#include <datasketches/hll/sketch.hpp>
#include <datasketches/quantiles/sketch.hpp>
datasketches::hll_sketch h;
datasketches::quantiles_sketch q;
```
Use sites stay readable that way, even with two sketch.hpp files in
different directories.
The filename-level overlap still has some ergonomic cost though: IDE
fuzzy search returns multiple sketch.hpp hits, compiler errors read
a bit worse, and there's some path-vs-class redundancy if hll appears
in both the directory and the class name.
I lean B from this thread, but A still works if the per-sketch
directory grouping turns out valuable as the library grows. Curious
what the others think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
