likyh commented on code in PR #2926:
URL: https://github.com/apache/incubator-devlake/pull/2926#discussion_r964331239
##########
config-ui/src/components/blueprints/DataScopesGrid.jsx:
##########
@@ -169,8 +169,8 @@ const DataScopesGrid = (props) => {
padding: 0,
}}
>
- {c.boards.map((board, bIdx) => (
- <li key={`list-item-key-${bIdx}`}>{board}</li>
+ {c.boardsList.map((board, bIdx) => (
Review Comment:
> No, for Advanced mode it's just a array of board titles, it gets mapped
and converted to Object boards for normal Mode. These props will get revised in
another ticket for now, there are different board props for easier use,
boardIds it's own prop array etc.
Sometimes boards is string array, sometimes is object array????? No, I don't
think it a good practice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
