e2corporation commented on code in PR #2926:
URL: https://github.com/apache/incubator-devlake/pull/2926#discussion_r964347301
##########
config-ui/src/pages/blueprints/blueprint-settings.jsx:
##########
@@ -579,20 +590,45 @@ const BlueprintSettings = (props) => {
useEffect(() => {
console.log('>>> ACTIVE BLUEPRINT ....', activeBlueprint)
const getGithubProjects = (c) => [Providers.GITHUB].includes(c.plugin)
- ? c.scope.map((s) => `${s.options.owner}/${s.options?.repo}`)
+ ? c.scope.map((s) => ({
+ id: `${s.options.owner}/${s.options?.repo}`,
+ key: `${s.options.owner}/${s.options?.repo}`,
+ value: `${s.options.owner}/${s.options?.repo}`,
+ title: `${s.options.owner}/${s.options?.repo}`,
+ }))
: []
const getGitlabProjects = (c) => [Providers.GITLAB].includes(c.plugin)
- ? c.scope.map((s) => s.options?.projectId)
+ ? c.scope.map((s) => ({
+ id: s.options?.projectId,
+ key: s.options?.projectId,
+ value: s.options?.projectId,
+ title: s.options?.title || `Project ${s.options?.projectId}`,
+ }))
: []
// @todo: handle multi-stage
const getAdvancedGithubProjects = (t, providerId) =>
[Providers.GITHUB].includes(providerId)
- ? [`${t.options?.owner}/${t.options?.repo}`]
+ ? [{
+ id: `${t.options.owner}/${t.options?.repo}`,
Review Comment:
We should add optional chaining (`?`) for `owner` here too like all the
other props.
```suggestion
id: `${t.options?.owner}/${t.options?.repo}`,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
