e2corporation commented on code in PR #2926:
URL: https://github.com/apache/incubator-devlake/pull/2926#discussion_r964338840
##########
config-ui/src/components/blueprints/DataScopesGrid.jsx:
##########
@@ -169,8 +169,8 @@ const DataScopesGrid = (props) => {
padding: 0,
}}
>
- {c.boards.map((board, bIdx) => (
- <li key={`list-item-key-${bIdx}`}>{board}</li>
+ {c.boardsList.map((board, bIdx) => (
Review Comment:
Whether you interact with an array of Objects, Strings or Integers, it
shouldn't be a problem for you. The differences and needs for rendering in
Normal Mode vs Advanced mode created the scenario for mixed types, not so much
the lack of good practices. Making them Objects in all scenarios wouldn't be a
problem either and things will most likely gravitate to that anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
