e2corporation commented on code in PR #3107:
URL: https://github.com/apache/incubator-devlake/pull/3107#discussion_r975649772
##########
config-ui/src/components/Nav.jsx:
##########
@@ -26,11 +26,41 @@ import {
import '@/styles/nav.scss'
import { ReactComponent as SlackIcon } from
'@/images/slack-mark-monochrome-black.svg'
import { ReactComponent as SlackLogo } from '@/images/slack-rgb.svg'
+import UIContext from '../store/UIContext'
+import useWindowSize from '../hooks/useWIndowSize'
+
const Nav = () => {
+ const uiContext = useContext(UIContext);
+ const [menuClass, setMenuClass] = useState("navbarMenuButton");
+ const size = useWindowSize();
+
+ const toggleSidebarOpen = (open) => {
+ uiContext.changeSidebarVisibility(open)
+ if (open){
+ setMenuClass("navbarMenuButtonSidebarOpened");
+ return;
+ }
+ setMenuClass("navbarMenuButton");
+ }
+
+ useEffect(() => {
Review Comment:
This Effect could also be refactored to be more declarative and remove the
nested `IF` statements
```suggestion
useEffect(() => {
toggleSidebarOpen(size.width >= 850 && uiContext.sidebarVisible !=
true ? true : false)
}, [size]);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
