e2corporation commented on PR #3107: URL: https://github.com/apache/incubator-devlake/pull/3107#issuecomment-1252726828
> Thank You @e2corporation for such a detailed Review, I will cover up on all your points and push the fixtures by tomorrow EOD Great work so far Henit! I'd like to run some functional tests later as well since I had some questions with the resize handling. I see the cleanup function has been added to the resize effect which is nice and will prevent memory leaks. One caveat of wrapping the whole app in a Context too is that it may cause unwanted re-renders which could impact form control components, so I just wanted to make sure there aren't any potential side effects. I also had another idea to extend this feature, which is to create a "Docked" mode for the sidebar (slim bar with DevLake logo + icons), which maybe something you might be interested in implementing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
