e2corporation commented on code in PR #3107:
URL: https://github.com/apache/incubator-devlake/pull/3107#discussion_r975654586
##########
config-ui/src/hooks/useWIndowSize.jsx:
##########
@@ -0,0 +1,29 @@
+import { useEffect, useState } from "react";
+
+function useWindowSize() {
+ const [windowSize, setWindowSize] = useState({
Review Comment:
Would it be better to initialize these to integer values rather than
undefined, or is undefined desired? Maybe even a min-viewport size of 320x240.
```suggestion
const [windowSize, setWindowSize] = useState({
width: 320,
height: 240,
})
```
##########
config-ui/src/hooks/useWIndowSize.jsx:
##########
@@ -0,0 +1,29 @@
+import { useEffect, useState } from "react";
+
+function useWindowSize() {
+ const [windowSize, setWindowSize] = useState({
Review Comment:
Would it be better to initialize these to integer values rather than
undefined, or is undefined desired? Maybe even a min-viewport size of 320x240.
```suggestion
const [windowSize, setWindowSize] = useState({
width: 320,
height: 240
})
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
