klesh commented on code in PR #3151: URL: https://github.com/apache/incubator-devlake/pull/3151#discussion_r1004275031
########## models/migrationscripts/20221015_create_singer_state.go: ########## @@ -0,0 +1,56 @@ +/* +Licensed to the Apache Software Foundation (ASF) under one or more +contributor license agreements. See the NOTICE file distributed with +this work for additional information regarding copyright ownership. +The ASF licenses this file to You under the Apache License, Version 2.0 +(the "License"); you may not use this file except in compliance with +the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package migrationscripts + +import ( + "github.com/apache/incubator-devlake/errors" + "github.com/apache/incubator-devlake/plugins/core" + "gorm.io/datatypes" + "time" +) + +type createTapState struct{} + +type SingerTapState20221015 struct { + Id string `gorm:"primaryKey;type:varchar(255)"` + ConnectionId uint64 + Type string + Value datatypes.JSON + CreatedAt time.Time + UpdatedAt time.Time +} + +func (SingerTapState20221015) TableName() string { + return "tap_state" +} + +func (*createTapState) Up(basicRes core.BasicRes) errors.Error { + err := basicRes.GetDal().AutoMigrate(SingerTapState20221015{}) + if err != nil { + return errors.Convert(err) Review Comment: I don't think we need the `errors.Convert` anymore ########## models/migrationscripts/20221015_create_singer_state.go: ########## @@ -0,0 +1,56 @@ +/* +Licensed to the Apache Software Foundation (ASF) under one or more +contributor license agreements. See the NOTICE file distributed with +this work for additional information regarding copyright ownership. +The ASF licenses this file to You under the Apache License, Version 2.0 +(the "License"); you may not use this file except in compliance with +the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package migrationscripts + +import ( + "github.com/apache/incubator-devlake/errors" + "github.com/apache/incubator-devlake/plugins/core" + "gorm.io/datatypes" + "time" +) + +type createTapState struct{} + +type SingerTapState20221015 struct { + Id string `gorm:"primaryKey;type:varchar(255)"` + ConnectionId uint64 + Type string + Value datatypes.JSON + CreatedAt time.Time + UpdatedAt time.Time +} + +func (SingerTapState20221015) TableName() string { + return "tap_state" Review Comment: For framework table, it should be prefixed by `_devlake_` ########## plugins/helper/batch_save_divider.go: ########## @@ -35,11 +35,12 @@ type BatchSaveDivider struct { db dal.Dal batches map[reflect.Type]*BatchSave batchSize int - table string - params string + rawTable string Review Comment: I think we should revert this file if we all agreed raw layer is neccessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
