klesh commented on code in PR #3151:
URL:
https://github.com/apache/incubator-devlake/pull/3151#discussion_r1012669052
##########
plugins/helper/api_rawdata.go:
##########
@@ -52,11 +52,12 @@ type RawDataSubTaskArgs struct {
// RawDataSubTask is Common features for raw data sub-tasks
type RawDataSubTask struct {
args *RawDataSubTaskArgs
- table string
- params string
+ Table string
Review Comment:
The reason these Fields are private is they should not be modified after
initialization.
Any accidental modified can cause bugs.
Maybe we should move this file to `models` module since it is part of the
infrastructure of the framework and shared by different helpers and change
these Fields to Methods to avoid modification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
