likyh commented on code in PR #3838:
URL:
https://github.com/apache/incubator-devlake/pull/3838#discussion_r1037745512
##########
plugins/jenkins/tasks/task_data.go:
##########
@@ -59,6 +59,16 @@ func DecodeAndValidateTaskOptions(options
map[string]interface{}) (*JenkinsOptio
if op.ConnectionId == 0 {
return nil, errors.BadInput.New("connectionId is invalid")
}
+ if op.JobFullName == "" {
+ return nil, errors.BadInput.New("JobFullName is required for
Jenkins execution")
+ }
+ if i := strings.LastIndex(op.JobFullName, `/`); i >= 0 {
+ op.JobName = op.JobFullName[i+1:]
+ op.JobPath = `job/` +
strings.Join(strings.Split(op.JobFullName[:i], `/`), `/job/`)
Review Comment:
only job name have. job path also needs a `job/` as the prefix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@devlake.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
